Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] support platform version #2778

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

Kudo
Copy link

@Kudo Kudo commented Dec 18, 2024

Why

support platform version from expo/expo#33637 to eas-cli

How

  • introduced getVersionConfigTarget to get related version field, value, and updater.
  • replace all fixed exp.version to use getVersionConfigTarget

Test Plan

add unit test for getVersionConfigTarget and bumpAppVersionAsync

Copy link

github-actions bot commented Dec 18, 2024

Size Change: +445 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +445 B (0%)

compressed-size-action

Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.57%. Comparing base (4bb550e) to head (e7b7eac).

Files with missing lines Patch % Lines
packages/eas-cli/src/build/ios/version.ts 50.00% 4 Missing ⚠️
packages/eas-cli/src/build/android/version.ts 66.67% 3 Missing ⚠️
packages/eas-cli/src/build/utils/version.ts 95.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2778      +/-   ##
==========================================
+ Coverage   52.52%   52.57%   +0.06%     
==========================================
  Files         583      583              
  Lines       22576    22608      +32     
  Branches     4450     4452       +2     
==========================================
+ Hits        11855    11884      +29     
- Misses      10686    10689       +3     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant